Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nutanix Builder #8175

Closed
wants to merge 2 commits into from
Closed

Add support for Nutanix Builder #8175

wants to merge 2 commits into from

Conversation

JRemitz
Copy link

@JRemitz JRemitz commented Oct 1, 2019

Adding support for Nutanix using the Nutanix Intentful API.

I've updated the docs for basic usage. This module is meant to leverage the upstream work from the nutanix terraform plugin structures with full intentions to leverage more code from the project (replacing the proprietary "driver" in this plugin). I currently have PR 81 with Terraform-Provider-Nutanix to support mapstructure within their data structs.

Some basic tests are included to validate the structures:

Known Issues:

  • No support for network proxy (yet)
  • Insecure SSL setting defaults to true

@JRemitz JRemitz requested a review from a team as a code owner October 1, 2019 05:12
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@SwampDragons
Copy link
Contributor

Hi @JRemitz, thanks for opening a PR!

Internally, we've been having a conversation about whether it makes sense to keep merging third party builders that we (HashiCorp) don't have the engineering resources to officially support -- I think it's been causing confusion in the community to have the officially-supported and community-supported plugins in the same place, and it makes the issue tracker a bit cluttered.

I'm working on a roadmap that will hopefully come up with a solution that makes managing the external plugins a bit more seamless, but I think for now at least we're not going to be merging new builders until that path forward has been figured out.

In the meantime, users can still use your builder -- you just need to add a file that serves it (an example can be found here). It's easier on users if you also build binaries for them, which you can serve via GitHub's releases tool. I can add your plugin's page here so that people know it exists and can find it, once you've gotten the plugin code working. If you need any help doing so, let me know.

I'll leave this PR open for now while we're figuring out what a better solution will look like.

@SwampDragons
Copy link
Contributor

We've officially decided to go the route of a "packer init" type feature, which we're hoping to roll out this year. With that in mind, I am going to close this PR, and I'll create a meta-issue to make sure that any builders added to our community pages get incorporated into the registry we create.

I would be happy to help you convert your builder into a third party plugin, or you can refer to our docs on how to do so: https://www.packer.io/docs/extending/plugins.html

It is worth noting that some of the interfaces changed between when you opened this PR and now; in order to get your plugin working you will want to take a look at

https://www.packer.io/guides/hcl/component-object-spec
and
https://www.packer.io/docs/extending/custom-builders.html

Thanks for understanding, and let me know if I can be any help.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants