Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packer plugin support ZStack #8152

Closed
wants to merge 1 commit into from
Closed

Conversation

koven2049
Copy link

@koven2049 koven2049 commented Sep 25, 2019

ZStack is an IaaS platform designed for private and hybrid cloud.
The PR integrated ZStack plugin to the Packer builder.

file change list:

  • CODEOWNERS
  • builder/zstack/
  • examples/zstack/
  • command/plugin.go
  • website/source/docs/builders/zstack-vminstance.html.md

Here are the plugin executes screenshot:
image

See more informations in builder/zstack/NOTE.md

@koven2049 koven2049 requested a review from a team as a code owner September 25, 2019 09:55
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@koven2049 koven2049 force-pushed the zstack branch 6 times, most recently from 3a1ec5c to 4a850fd Compare September 25, 2019 12:43
@koven2049
Copy link
Author

@hashicorp-cla please check my cla status

@SwampDragons
Copy link
Contributor

Hi @koven2049, thanks for opening!

Internally, we've been having a conversation about whether it makes sense to keep merging third party builders that we (HashiCorp) don't have the engineering resources to officially support -- I think it's been causing confusion in the community to have the officially-supported and community-supported plugins in the same place, and it makes the issue tracker a bit cluttered.

I'm working on a roadmap that will hopefully come up with a solution that makes managing plugins a bit more seamless so that users don't have to worry about compiling, etc... but I think for now at least we're not going to be merging new builders until that path forward has been figured out.

I'm happy to leave this open while we're deliberating on that, but it'll be a while and my suspicion at this point is that we're going to end up saying "keep it separate as a third party builder that you (ZStack) maintain".

In the meantime, if you have a repo that currently provides the ZStack as a third party plugin, I'd love to link it in our docs so that users can find it.

If you need help figuring out how to provide ZStack as a third party plugin, you can take a look at our docs page here: https://www.packer.io/docs/extending/plugins.html

Thanks for opening this!

@koven2049
Copy link
Author

Thanks for your reply @SwampDragons . I understand it's not an easy way to find out how to constraint the third party plugins. ZStack(https://github.com/zstackio) is an open source IaaS platform also and we met the same problem before. I am a pleasure to handle our builder in my repo at present and to post a doc later. In the meanwhile I 'm sincerely to expect the official roadmap and wish to merge the ZStack builder anytime.

@SwampDragons
Copy link
Contributor

We've officially decided to go the route of a "packer init" type feature, which we're hoping to roll out this year. With that in mind, I am going to close this PR, and I'll create a meta-issue to make sure that any builders added to our community pages get incorporated into the registry we create.

I would be happy to help you convert your builder into a third party plugin, or you can refer to our docs on how to do so: https://www.packer.io/docs/extending/plugins.html

It is worth noting that some of the interfaces changed between when you opened this PR and now; in order to get your plugin working you will want to take a look at

https://www.packer.io/guides/hcl/component-object-spec
and
https://www.packer.io/docs/extending/custom-builders.html

Thanks for understanding, and let me know if I can be any help.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants