builder/amazonebs: Move SSH.new into ConnectWaitLoop #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EC2 images can sometimes accept a connection on port 22 without truly being ready to complete SSH. For example, it may not complete the full hand-shake (closing the connection immediately) or it may not have the appropriate public keys in place. The prior code would only attempt an SSH handshake once, which would unnecessarily fail the build in these instances. Fix hashicorp#130 by moving SSH.new into the loop that retries connections, and improve debuggability by logging the failure causes on each connection fail. Signed-off-by: Emil Sit <[email protected]>
|
Ah, so unfortunately this solves one issue but introduces another. The issue is that SSH handshakes have REALLY long timeouts. But generally it is clear they're going to time out if they don't finish in around 5 or so seconds. For this reason, you actually need to do something similar to the virtualbox wait_for_ssh step: This extra complicated step is the reason I haven't quickly merged this. If you want to just repurpose the VirtualBox step to AWS, I'd be open to that. For now, I'm going to close this PR because the changes needed are pretty vast. But if you end up applying it in this way, feel free to open another PR. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EC2 images can sometimes accept a connection on port 22 without
truly being ready to complete SSH. For example, it may not complete
the full hand-shake (closing the connection immediately) or it may
not have the appropriate public keys in place. The prior code
would only attempt an SSH handshake once, which would unnecessarily
fail the build in these instances.
Fix #130 by moving SSH.new into the loop that retries connections,
and improve debuggability by logging the failure causes on each
connection fail.
Signed-off-by: Emil Sit [email protected]