Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix force flag for hcl2 provisioners and post-processors #10571

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Fix force flag for hcl2 provisioners and post-processors #10571

merged 3 commits into from
Feb 5, 2021

Conversation

sylviamoss
Copy link
Contributor

This PRs passes the config flags force, debug, and on-error to provisioners and post-processors for hcl2 config. Also, updates some only/except hcl2 examples that were wrong.

Closes #10536
Closes #10555

@sylviamoss sylviamoss requested a review from a team as a code owner February 4, 2021 15:43
@codecov
Copy link

codecov bot commented Feb 4, 2021 •
edited
Loading

Codecov Report

Merging #10571 (d648d93) into master (3ddb17a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
hcl2template/types.build.post-processor.go 59.67% <100.00%> (+3.53%) ⬆️
hcl2template/types.build.provisioners.go 48.33% <100.00%> (+2.24%) ⬆️
hcl2template/types.packer_config.go 55.78% <100.00%> (+0.40%) ⬆️
hcl2template/types.source.go 81.25% <100.00%> (ø)

nywilken
nywilken approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good me. Nicely done.

azr
azr approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !

@sylviamoss sylviamoss merged commit ef4afaf into master Feb 5, 2021
@sylviamoss sylviamoss deleted the fix_force_flag branch February 5, 2021 09:57
@zahidkhan262

This comment has been minimized.

Sign in to view
@azr azr mentioned this pull request Feb 5, 2021
Closed
@SwampDragons SwampDragons added this to the 1.7.0 milestone Feb 9, 2021
@sylviamoss sylviamoss mentioned this pull request Feb 12, 2021
Closed
@ghost
Copy link

ghost commented Mar 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

@azr azr azr approved these changes

@SwampDragons SwampDragons SwampDragons approved these changes

Assignees
No one assigned
Labels
bug hcl2
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

only does not worked as documented in HCL PostProcessor does not respect PackerConfig.PackerForce
5 participants
@sylviamoss @zahidkhan262 @SwampDragons @azr @nywilken