Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit comparison to bool constant #479

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Summary

Simplifies the condition for checking if the image import request was created.

➜ staticcheck builder/vsphere/supervisor/step_import_image.go                                             
builder/vsphere/supervisor/step_import_image.go:166:69: should omit comparison to bool constant, can be simplified to !v.(bool) (S1002)
➜ staticcheck builder/vsphere/supervisor/step_import_image.go                                             
➜

Omit comparison to bool constant.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Oct 16, 2024
@tenthirtyam tenthirtyam self-assigned this Oct 16, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 16, 2024 00:25
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 58d9b55 into main Oct 16, 2024
14 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/omit-comparison-to-bool-constant branch October 16, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants