Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: http_ip warn vs err #475

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: http_ip warn vs err #475

merged 1 commit into from
Oct 15, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Updates ValidateHTTPAddress to simply log a warning if the http_ip is not bound to an interface instead of error.

Closes #474

Updates `ValidateHTTPAddress` to simply log a warning if the `http_ip` is not bound to an interface instead of error.

Ref: #474

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Oct 9, 2024
@tenthirtyam tenthirtyam self-assigned this Oct 9, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 9, 2024 20:45
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit bd61340 into main Oct 15, 2024
14 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/httpip-intf-warn branch October 15, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use http_ip when running in a container
2 participants