Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sata controller #451

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Jul 9, 2024

Description

Testing

packer-plugin-vsphere on  feat/add-sata-controller [!] via 🐹 v1.22.5 go get github.com/vmware/govmomi@57aea68935dca95a7bb8f73c3ffb4b9905753861
go: downgraded github.com/vmware/govmomi v0.38.0 => v0.31.1-0.20240708220642-57aea68935dc

packer-plugin-vsphere on  feat/add-sata-controller [!] via 🐹 v1.22.5 make build

Update Test: TestAddStorageDevices

func TestAddStorageDevices(t *testing.T) {
	config := &StorageConfig{
		DiskControllerType: []string{"sata"},
		Storage: []Disk{
			{
				DiskSize:            3072,
				DiskThinProvisioned: true,
				ControllerIndex:     0,
			},
			{
				DiskSize:            20480,
				DiskThinProvisioned: true,
				ControllerIndex:     0,
			},
		},
	}
...
packer-plugin-vsphere on  feat/add-sata-controller [!] via 🐹 v1.22.5 make test                                                                
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.685s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       4.820s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       7.458s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  4.856s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   9.294s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       3.686s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      4.633s
Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAddStorageDevices$ github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver

ok  	github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver	(cached)
Starting: /Users/johnsonryan/go/bin/dlv dap --listen=127.0.0.1:59579 --log-dest=3 from /Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/packer-plugin-vsphere/builder/vsphere/driver
DAP server listening at: 127.0.0.1:59579
Type 'dlv help' for list of commands.
PASS
Process 96747 has exited with status 0
Detaching
dlv dap (95836) exited with code: 0

Reference

Closes #42

@tenthirtyam tenthirtyam added this to the On Deck milestone Jul 9, 2024
@tenthirtyam tenthirtyam requested a review from nywilken July 9, 2024 20:37
@tenthirtyam tenthirtyam self-assigned this Jul 9, 2024
@tenthirtyam
Copy link
Collaborator Author

CI failures are expected until the upstream is merged, released, and this go.mod updated.

@tenthirtyam tenthirtyam added stage/waiting-on-upstream This issue is waiting on an upstream change dependencies builder/vsphere-iso Builder: vsphere-iso labels Jul 10, 2024
@tenthirtyam tenthirtyam changed the title 🚧 feat: add sata controller feat: add sata controller Jul 11, 2024
@tenthirtyam tenthirtyam force-pushed the feat/add-sata-controller branch from 5e3e802 to 4c9310b Compare July 22, 2024 18:26
@tenthirtyam tenthirtyam removed the stage/waiting-on-upstream This issue is waiting on an upstream change label Jul 22, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.0, v1.3.1 Jul 22, 2024
@tenthirtyam tenthirtyam force-pushed the feat/add-sata-controller branch 3 times, most recently from 2ce6442 to b200a6e Compare July 22, 2024 18:48

Verified

This commit was signed with the committer’s verified signature.
tenthirtyam Ryan Johnson
- Adds support for a `disk_controller_type = "sata"`.
- Updates `vmware/govmomi` to v0.39.0 to support the option.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the feat/add-sata-controller branch from b200a6e to e8bd7b7 Compare July 22, 2024 18:52
@tenthirtyam tenthirtyam marked this pull request as ready for review July 22, 2024 18:58
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 22, 2024 18:58
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 8e5830a into main Jul 24, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the feat/add-sata-controller branch July 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsphere-iso: Add support for SATA disk_controller_type
2 participants