-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for export to ova #409
Conversation
d207291
to
24bf114
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving since overall this looks good to me, just left a couple nits, but we're close to merge imo!
24bf114
to
97a2527
Compare
Comments addressed in 97a2527. Running another round of tests to ensure all is still well. |
Adds support to export a virtual machine image to either to the default Open Virtualization Format (`ovf`) or convert to Open Virtualization Archive (.ova). Note: To use the `ova` format option, VMware ovftool must be installed on the Packer host and accessible in either the system `PATH` or the user's `PATH`. This is noted in the documentation. Signed-off-by: Ryan Johnson <[email protected]>
97a2527
to
4e2c30b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the rerolls
Summary
Adds support to export a virtual machine image to either to the default Open Virtualization Format (
ovf
) or convert to Open Virtualization Archive (.ova).Note
To use the
ova
format option, VMware ovftool must be installed on the Packer host and accessible in either the systemPATH
or the user'sPATH
. This is noted in the documentation.Testing
Standard Build and Tests:
Additional Tests
✅ PASS: Export without setting
Format
. Defaults toovf
.✅ PASS: Export without setting
Format
. Defaults toovf
. Expected error for existingovf
file found.✅ PASS: Export without setting
Format
withforce = true
. Defaults toovf
. Existingovf
overwritten.✅ PASS: Export setting
Format
toova
withoutovftool
installed or inPATH
. Expected error.✅ PASS: Export setting
Format
toova
.✅ PASS: Export setting
Format
toova
. Expected error for existingova
file found and intermediate files removed.✅ PASS: Export setting
Format
toova
withforce = true
. Existingova
overwritten and intermediate files removed.Reference
Closes #17
VMware Open Virtualization Format Tool (
ovftool
).