Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip unix-style permissions #404

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

tenthirtyam
Copy link
Collaborator

If running on Windows, do not attempt to apply Unix-style permissions to the artifact output.

Closes #280

@tenthirtyam tenthirtyam added this to the v1.2.8 milestone Apr 12, 2024
@tenthirtyam tenthirtyam self-assigned this Apr 12, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 12, 2024 03:43
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a nit, but aside from that LGTM!

builder/vsphere/common/output_config.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam force-pushed the fix/skip-unix-style-permissions branch from 8c1c879 to e75a4ae Compare April 12, 2024 14:40
If running on Windows, do not attempt to apply  Unix-style permissions to the artifact output.

Ref: #280

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the fix/skip-unix-style-permissions branch from e75a4ae to 067acbf Compare April 12, 2024 14:47
@lbajolet-hashicorp lbajolet-hashicorp merged commit 0f368ae into main Apr 12, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/skip-unix-style-permissions branch April 12, 2024 14:54
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to output file permission and ownership
2 participants