-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for precision clock device #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes provided. Additinally, the following privledges would also need to be noted in the documentation.
Virtual Machine.Configuration
: Add or remove deviceVirtual machine.Configuration:
Modify device settings
docs-partials/builder/vsphere/common/HardwareConfig-not-required.mdx
Outdated
Show resolved
Hide resolved
8c91c17
to
ca29ee1
Compare
I've corrected the CI issues, updated the description, and squashed the commits. Results attached in the Tests section. |
f63791d
to
aac9560
Compare
Add support for adding a precision clock device to a virtual machine during the image build. Co-Authored-By: Ryan Johnson <[email protected]>
e9a65bd
to
169fe48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Reviewed and updated as applicable.
This MR started like i sorta knew what i was doing. That escalated quickly... |
Nah, great job in adding the capability. This contribution is most welcome. In fact, there is a need to do the same in the Terraform provider, too. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for the contribution @xtalkme
@tenthirtyam as always thanks for the review and pushing this change forward. 💙
These changes allow you to define a VirtualPrecisionClock device.
Reference
Closes #354
Tests
From @tenthirtyam