Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update vsphere-supervisor test to skip output from retry #321

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: update vsphere-supervisor test to skip output from retry #321

merged 1 commit into from
Nov 9, 2023

Conversation

dilyar85
Copy link
Contributor

@dilyar85 dilyar85 commented Nov 9, 2023

This PR updates the Supervisor test util function checkOutputLines to skip the current actual output if it contains "continue checking" line. This is to avoid failing the test in step_watch_source.go where the VM ingress IP may not be set immediately, causing retry.Config to output "continue checking" and retry.

Testing Done:

$ go test -count=100 -run ^TestWatchSource_Run$ github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor 
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   100.849s

@dilyar85 dilyar85 requested a review from a team as a code owner November 9, 2023 15:07
@dilyar85 dilyar85 mentioned this pull request Nov 9, 2023
Merged
nywilken
nywilken approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the test case so quickly. This looks good to me.

@nywilken nywilken added tech-debt builder/vsphere-supervisor Builder: vsphere-supervisor labels Nov 9, 2023
@nywilken nywilken merged commit cbbe8fa into hashicorp:main Nov 9, 2023
12 checks passed
@tenthirtyam tenthirtyam changed the title Update Supervisor test to skip output from retry fix: update vsphere-supervisor test to skip output from retry Nov 9, 2023
@dilyar85 dilyar85 mentioned this pull request Nov 9, 2023
Merged
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees

@dilyar85 dilyar85

Labels
builder/vsphere-supervisor Builder: vsphere-supervisor tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilyar85 @nywilken