Fix handling of temporary cdrom devices

[puetzk]

Fix two more issues with vmware and cd_{files,content}

1. if a temporary cdPath is set up, during step_configure_vmx, it should be claned up by step_clean_vmx
   There is already code to do this cleanup, but it wasn't triggering because it was only applied to vmware-iso (and had the wrong device name there). Only floppies were added to temporaryDevices when the setup was actually being done.

2. Fix updating/overwriting existing cdrom device properties (case-sensitivity)
   packer lowercases all the vmx keys when reading a file in:

   packer-plugin-vmware/builder/vmware/common/vmx.go

   Line 28 in e38fb92

   key := strings.ToLower(matches[1])

   so using mixed-case keys to update the .vmx introduces semantic duplicates (rather than replacing old values)
   

   packer-plugin-vmware/builder/vmware/common/step_configure_vmx.go

   Lines 94 to 95 in e38fb92

   	vmxData[cdromPrefix+".fileName"] = cdPath.(string)
   	vmxData[cdromPrefix+".deviceType"] = "cdrom-image"

[puetzk]

Hmm, just noticed one flaw in this PR - StepConfigureVMX actually runs twice:

packer-plugin-vmware/builder/vmware/vmx/builder.go

Lines 103 to 109 in e38fb92

	&vmwcommon.StepConfigureVMX{
	CustomData: b.config.VMXData,
	VMName: b.config.VMName,
	DisplayName: b.config.VMXDisplayName,
	DiskAdapterType: b.config.DiskAdapterType,
	CDROMAdapterType: "",
	},

packer-plugin-vmware/builder/vmware/vmx/builder.go

Lines 166 to 170 in e38fb92

	&vmwcommon.StepConfigureVMX{
	CustomData: b.config.VMXDataPost,
	SkipFloppy: true,
	VMName: b.config.VMName,
	DisplayName: b.config.VMXDisplayName,

And the CD data is set both times, so it actually attempts to overwrite itself (harmless, if a little weird), but that now means it adds
the cdrom twice: https://github.com/hashicorp/packer-plugin-vmware/pull/31/files#diff-9a390b1c72b8076046aeb82247ce79248acca5ac5dd9bf7f6c161d378649514fR101

and that's confirmed in the log:

vmware: Cleaning VMX prior to finishing up...
vmware: Detaching ISO from CD-ROM device ide1:0...
vmware: Detaching ISO from CD-ROM device ide1:0...

It looks like floppy avoids this because of SkipFloppy - I wonder if we should just generalize that to SkipDevices, since it really doesn't make sense create temp devices right before (with nothing in between) StepCleanVmx. The later StepConfigureVMX is just setting the VMXDataPost (and, for some reason, resetting the name and DisplayName)

packer-plugin-vmware/builder/vmware/common/step_configure_vmx.go

Lines 80 to 81 in e38fb92

	// Add it to our list of build devices to later remove
	tmpBuildDevices = append(tmpBuildDevices, "floppy0")

Cleaning up is idempotent, so doing it twice is better than zero times like before, but that's a little untidy.

[azr]

Hey @puetzk, super nice, this LGTM & worked on my machine ! Thanks for your time again 🙂

[azr]

👍🏼

[arizvisa]

Ftr, there was some further discussion in #31 that might affect this PR. So I'm noting it in this PR's history despite it already being merged.

[azr]

👋🏼 @arizvisa, thanks. Is #31 the PR you meant ? I think probably not, since it's this one.

Edit: I think you mean #33

[arizvisa]

@azr: Ah, yes. My bad.