Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update grammar #265

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore: update grammar #265

merged 1 commit into from
Dec 5, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Updates grammar in comments and documentation, as needed.

@tenthirtyam tenthirtyam added the chore Chore label Dec 4, 2024
@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Dec 4, 2024
@tenthirtyam tenthirtyam self-assigned this Dec 4, 2024
@tenthirtyam tenthirtyam changed the title hore: update grammar chore: update grammar Dec 4, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review December 4, 2024 03:37
@tenthirtyam tenthirtyam requested a review from a team as a code owner December 4, 2024 03:37
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a couple nits on some comments, but overall we are good to go.
I'll let you address those and come back for a second review.

Pre-approving for later!

builder/vmware/common/driver_parser.go Outdated Show resolved Hide resolved
builder/vmware/common/driver_parser.go Show resolved Hide resolved
Updates grammar in comments and documentation, as needed.

Signed-off-by: Ryan Johnson <[email protected]>
@lbajolet-hashicorp lbajolet-hashicorp merged commit bc98c53 into main Dec 5, 2024
14 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/update-grammar branch December 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants