Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update run config #223

Merged
merged 1 commit into from
Jul 17, 2024
Merged

chore: update run config #223

merged 1 commit into from
Jul 17, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Description

  • Updates comments for more streamlined documentation.
  • Removes the use of "magic" numbers and defines constants.

Testing

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 took 10.0s go fmt ./... 
builder/vmware/common/run_config_test.go

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 make generate
2024/07/07 23:09:07 Copying "docs" to ".docs/"
2024/07/07 23:09:07 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 make build   

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 make test    
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.592s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    2.271s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    1.836s

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 took 8.9s make dev     
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

- Updates comments for more streamlined documentation.
- Removes the use of "magic" numbers and defines constants.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added documentation Improvements or additions to documentation tech-debt chore Chore labels Jul 8, 2024
@tenthirtyam tenthirtyam added this to the v1.0.12 milestone Jul 8, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 8, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 8, 2024 03:16
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit 7fa57d8 into main Jul 17, 2024
12 checks passed
@nywilken nywilken deleted the chore/update-run-config branch July 17, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore documentation Improvements or additions to documentation tech-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants