refactor: tools upload flavors

[tenthirtyam]

Description

Refactors to use allowedToolsFlavorValues for tools upload flavor options based on constants.

Testing

✅ Standard

packer-plugin-vmware on  refactor/tools-config [$!] via 🐹 v1.22.5 
➜ go fmt ./... 

packer-plugin-vmware on  refactor/tools-config [$!] via 🐹 v1.22.5 
➜ make generate
2024/08/06 18:07:58 Copying "docs" to ".docs/"
2024/08/06 18:07:58 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  refactor/tools-config [$!] via 🐹 v1.22.5 
➜ make build

packer-plugin-vmware on  refactor/tools-config [$!] via 🐹 v1.22.5 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.666s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.516s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    1.888s

packer-plugin-vmware on  refactor/tools-config [$!] via 🐹 v1.22.5 took 8.4s 
➜ make dev 
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

✅ Configuration

1. 'foo'

source "vmware-iso" "vagrant-vmw" {
  # ... brevity ...
  tools_upload_flavor = "foo"
}

✦7 ➜ PACKER_LOG=1 PACKER_LOG_PATH=packer.log packer build --force -var-file=photon-4.0-R2.pkrvars.hcl .
Error: 1 error(s) occurred:

* invalid 'tools_upload_flavor' specified: foo; must be one of darwin, linux, windows

2. 'linux'

source "vmware-iso" "vagrant-vmw" {
  # ... brevity ...
  tools_upload_flavor = "linux"
}

==> vmware-iso.vagrant-vmw: Connected to SSH!
==> vmware-iso.vagrant-vmw: Uploading VMware Tools (linux)...
==> vmware-iso.vagrant-vmw: Provisioning with shell script: /Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/photon-packer-templates/scripts/system/update-packages.sh

2024/08/06 18:33:55 ui: �[1;32m==> vmware-iso.vagrant-vmw: Connected to SSH!�[0m
2024/08/06 18:33:55 ui: �[1;32m==> vmware-iso.vagrant-vmw: Uploading VMware Tools (linux)...�[0m
2024/08/06 18:33:55 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:55 [DEBUG] Opening new ssh session
2024/08/06 18:33:55 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:55 [DEBUG] Starting remote scp process:  scp -vt .
2024/08/06 18:33:55 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:55 [DEBUG] Started SCP session, beginning transfers...
2024/08/06 18:33:55 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:55 [DEBUG] Copying input data into temporary file so we can read the length
2024/08/06 18:33:55 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:55 [DEBUG] scp: Uploading linux.iso: perms=C0644 size=58617856
2024/08/06 18:33:56 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:56 [DEBUG] SCP session complete, closing stdin pipe.
2024/08/06 18:33:56 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:56 [DEBUG] Waiting for SSH session to complete.
2024/08/06 18:33:56 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: 2024/08/06 18:33:56 [DEBUG] scp stderr (length 70): Sink: C0644 58617856 linux.iso
2024/08/06 18:33:56 packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_amd64 plugin: scp: debug1: fd 0 clearing O_NONBLOCK

[lbajolet-hashicorp]

Left a few nits, but overall the change looks good to me! Pre-approving to not block a later merge, I'll let you address those @tenthirtyam and will do another review then!

[lbajolet-hashicorp]

Just to be sure, I would create this as a var to have the returned slice be nil, that way you can compare the returned slice to nil, as it will effectively be if no errors have been found.

That said, given there's only one error returned at a time, is there a reason this is a slice of errors instead of a single error?