chore: deprecated ssh_skip_request_pty

Deprecated `ssh_skip_request_pty` per comment: ``` // These are deprecated, but we keep them around for BC // TODO(@mitchellh): remove" ``` Signed-off-by: Ryan Johnson <[email protected]>
hashicorp · Jul 29, 2024 · 35732ba · 35732ba
1 parent 4c6726a
commit 35732ba
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/builder/vmware/common/ssh_config.go b/builder/vmware/common/ssh_config.go
@@ -6,21 +6,23 @@
 package common
 
 import (
+	"log"
+
 	"github.com/hashicorp/packer-plugin-sdk/communicator"
 	"github.com/hashicorp/packer-plugin-sdk/template/interpolate"
 )
 
 type SSHConfig struct {
 	Comm communicator.Config `mapstructure:",squash"`
 
-	// These are deprecated, but we keep them around for BC
-	// TODO(@mitchellh): remove
+	// TODO: Deprecated. Remove in next major release
 	SSHSkipRequestPty bool `mapstructure:"ssh_skip_request_pty"`
 }
 
 func (c *SSHConfig) Prepare(ctx *interpolate.Context) []error {
 	if c.SSHSkipRequestPty {
 		c.Comm.SSHPty = false
+		log.Printf("[WARN] 'ssh_skip_request_pty' is deprecated and will be removed in the next major release.")
 	}
 
 	return c.Comm.Prepare(ctx)