Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to code to unmount cdrom due to change in proxmox format #85

Merged
merged 1 commit into from
May 25, 2022
Merged

Change to code to unmount cdrom due to change in proxmox format #85

merged 1 commit into from
May 25, 2022

Conversation

Quiphius
Copy link
Contributor

@Quiphius Quiphius commented May 6, 2022

Proxmox has changed the config format of the cdrom and HasSuffix won't work anymore, changed to Contains to allow the string "media=cdrom" to be anywhere in the response.

Closes #83

@Quiphius Quiphius requested a review from a team as a code owner May 6, 2022 15:48
@walmins
Copy link

walmins commented May 13, 2022

Hello people,
do you schedule the merge date for this bug because we are blocked also?

Thanks

@vrubiolo
Copy link

Hi there,

We are interested by the fix too as we hit this issue this week and are also blocked. Let us know if you need assistance testing things.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review here. This looks good to me. Thank you for the fix.
It will go out with the next release, which will happen fairly soon.

@nywilken nywilken merged commit 1ac7ee1 into hashicorp:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails to unmount iso when finished
4 participants