Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] packer ignores pool parameter #77

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

mizhka
Copy link
Contributor

@mizhka mizhka commented Apr 5, 2022

The plugin ignores "pool" parameter due to incorrect copying of parameter value
into ConfigQemu. For example, in case of clone-vm for pooled template it results
into excluding of VM from pool.

This patch set "pool" parameter of ConfigQemu if parameter is not empty.

The plugin ignores "pool" parameter due to incorrect copying of parameter value
into ConfigQemu. For example, in case of clone-vm for pooled template it results
into excluding of VM from pool.

This patch set "pool" parameter of ConfigQemu if parameter is not empty.
@mizhka mizhka requested a review from a team as a code owner April 5, 2022 12:37
@nywilken nywilken added the bug label Apr 6, 2022
Copy link
Contributor

@carlpett carlpett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@nywilken nywilken merged commit c6ba814 into hashicorp:main Apr 15, 2022
@mizhka
Copy link
Contributor Author

mizhka commented Apr 18, 2022

@nywilken , @carlpett , thank you for quick response! I really appreciate your support.
Waiting for next release to enjoy packer with Proxmox pools.

@nywilken
Copy link
Contributor

Hi @mizhka happy to support. Thanks for the contributions. I'll be making a release of the plugin today. If you are not using HCL2 templates already I recommend looking into the hcl2_upgrade command and the required_plugins block to help with installing and using new plugin releases as they become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants