Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse search order for ide disks for cloud-init allocation. #56

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

jeff-voight
Copy link
Contributor

Reverses the order of the cloud-init ide drive selection to start at low numbers instead of starting at high numbers.

This solves an issue where when building an image with cloud-init enabled, proxmox reports the following:

generating cloud-init ISO
kvm: -device ide-cd,bus=ide.1,unit=1,drive=drive-ide3,id=ide3: Can't create IDE unit 1, bus supports only 1 units
TASK ERROR: start failed: QEMU exited with code 1

Closes Plugin assigns bad ide drive to cloud-init #55

Can be tested by cloning: https://github.com/VoightCloud/CopperCentos7.git

Modify username to your proxmox packer username, modify token to your proxmox token, modify node to your node, modify proxmox_url to your proxmox_url, upload Centos-7-x86_64-Everything-2009.iso to your local:iso/ storage.

cd into packer directory and type ./build.sh

@jeff-voight jeff-voight requested a review from a team as a code owner December 19, 2021 03:28
@hashicorp-cla
Copy link

hashicorp-cla commented Dec 19, 2021

CLA assistant check
All committers have signed the CLA.

@jeff-voight
Copy link
Contributor Author

I think the ci/circleci tests may have to re-run. I saw failures that lead me to believe that something else is stuck in the pipeline that's affecting my build.

@azr
Copy link
Contributor

azr commented Dec 20, 2021

cc @carlpett 🙂

@carlpett
Copy link
Contributor

Change itself looks fine, thanks! The context around has quite odd indentation though, could you check if it is gofmt:ed? (Could just be Github acting up)

@azr
Copy link
Contributor

azr commented Dec 21, 2021

+1, also, the TestTemplateFinalize/all_options_with_cloud-init test seems to fail.

Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@azr azr merged commit e68ae2f into hashicorp:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants