[Issue 281] Fix pool config regression #282
Conversation
There was a problem hiding this comment.
LGTM, thanks for addressing this @mpywell !
I left a small nit on the generateAgentConfig function, but outside of this, we're good to go.
I'll let you address the comment and I'll be back for a second pass after that.
Pre-approving to not delay merging later.
| @@ -254,6 +250,30 @@ func (s *stepStartVM) Run(ctx context.Context, state multistep.StateBag) multist | |||
| return multistep.ActionContinue | |||
| } | |||
|
|
|||
| func generateAgentConfig(agent config.Trilean) *proxmox.QemuGuestAgent { | |||
There was a problem hiding this comment.
Do we plan to add more to this function? It seems to me that this could be simplified to &proxmox.QemuGuestAgent{Enable:agent.True()} otherwise
There was a problem hiding this comment.
I did consider proxmox.QemuGuestAgent{Enable:agent.True()} at first but I had a look over the open issues and decided to set this up as a function so I could address #276 in another PR
|
Hey @lbajolet-hashicorp comment addressed, should be good to go. |
|
Sounds good, thanks for the update @mpywell! Merging this one now, I'll release a new version of the plugin with that fix in since it's a regression introduced in 1.2.0, so 1.2.1 coming-up today hopefully! |
A regression was introduced by the proxmox-api-go version used in v1.2.0, which was fixed in version
v0.0.0-20240525163725-6676d8933df0. Some other API changes had occurred around Tags and QEMU Agent configuration which have been handled and tested as part of this PR.Closes #281