-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add efi_format options to efi_config #272
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Giorgio Premi seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
I've changed the author email address in order to comply with your CLA, but the bot is not happy yet :) |
Hi @giosh94mhz, Looks like it is now yes, the second comment it left seems out-of-date, you should be good to go on this front :) I'll review the PR later today or tomorrow as I'm focusing on something else for now, we'll let the tests run in the meantime and I'll come back with an update later. Thanks! |
Looking forward to this one! |
Using this option is possibile to create qcow2 EFI disks, instead of the default raw backend.
b1e6fd3
to
670e428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @giosh94mhz,
Thanks for the PR! Apologies I didn't review it sooner, I had left a message on the PR, but forgot to come back to it; thanks to @trenta for bumping it up!
I pushed an update to the code since some of the generated documentation was not committed along with the changes, should be good now.
Once the tests are green I'll merge this!
Thanks very much! |
Using this option is possible to create qcow2 EFI disks, instead of the default raw backend.
In previous version of the plugin (with packer 1.9 IIRC), there was a "global" option
format = "qcow2"
which applied also to EFi disks. When the configuration was changed todisks
andefi
sections, we lost the ability to set disk to qcow format.Having EFI disk in qcow2 format is important, because the raw disks prevent snapshot to be taken.
I've searched the tests suite for EFI configuration to attach my changes, but I found none. I'm sorry, but I'm not quite sure how to write a new test, so I had to leave that to you. Of course, I tested the plug-in on our infrastructure (Proxmox 7.4 + Packer 1.11)