Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efi_format options to efi_config #272

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

giosh94mhz
Copy link
Contributor

Using this option is possible to create qcow2 EFI disks, instead of the default raw backend.

In previous version of the plugin (with packer 1.9 IIRC), there was a "global" option format = "qcow2" which applied also to EFi disks. When the configuration was changed to disks and efi sections, we lost the ability to set disk to qcow format.

Having EFI disk in qcow2 format is important, because the raw disks prevent snapshot to be taken.

I've searched the tests suite for EFI configuration to attach my changes, but I found none. I'm sorry, but I'm not quite sure how to write a new test, so I had to leave that to you. Of course, I tested the plug-in on our infrastructure (Proxmox 7.4 + Packer 1.11)

@giosh94mhz giosh94mhz requested a review from a team as a code owner July 9, 2024 07:05
Copy link

hashicorp-cla-app bot commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Giorgio Premi seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@giosh94mhz
Copy link
Contributor Author

I've changed the author email address in order to comply with your CLA, but the bot is not happy yet :)

@lbajolet-hashicorp
Copy link
Contributor

Hi @giosh94mhz,

Looks like it is now yes, the second comment it left seems out-of-date, you should be good to go on this front :)

I'll review the PR later today or tomorrow as I'm focusing on something else for now, we'll let the tests run in the meantime and I'll come back with an update later.

Thanks!

@trenta
Copy link

trenta commented Sep 16, 2024

Looking forward to this one!

Using this option is possibile to create qcow2 EFI disks,
instead of the default raw backend.
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @giosh94mhz,

Thanks for the PR! Apologies I didn't review it sooner, I had left a message on the PR, but forgot to come back to it; thanks to @trenta for bumping it up!

I pushed an update to the code since some of the generated documentation was not committed along with the changes, should be good now.

Once the tests are green I'll merge this!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 681ccf4 into hashicorp:main Sep 16, 2024
12 checks passed
@trenta
Copy link

trenta commented Sep 16, 2024

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants