Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation of network_adapters #244

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ledif
Copy link
Contributor

@ledif ledif commented Dec 25, 2023

This PR fixes a small typo for the description of network_adapters, which appears to have been copied without modification from the vga option.

@ledif ledif requested a review from a team as a code owner December 25, 2023 23:13
@hashicorp-cla
Copy link

hashicorp-cla commented Dec 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ledif,

Thanks for catching this, LGTM!

@lbajolet-hashicorp lbajolet-hashicorp force-pushed the docs-type-network-adapter branch from 2cf881d to 048c9cf Compare January 9, 2024 16:33
@lbajolet-hashicorp
Copy link
Contributor

FYI: since the change only impacted the go code, this failed in CI as the docs generated from the code weren't regenerated. I took the liberty to do so locally and force-pushed on your branch with that change in.

@lbajolet-hashicorp lbajolet-hashicorp merged commit a0268f4 into hashicorp:main Jan 9, 2024
12 checks passed
@ledif ledif deleted the docs-type-network-adapter branch January 9, 2024 19:59
@lbajolet-hashicorp lbajolet-hashicorp added the documentation Improvements or additions to documentation label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants