builder: don't use setParamIfDefined on bools #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `setDeviceParamIfDefined' function only works on strings, and checks that the value is not empty before adding the parameter to the request. In the builder code, in several places, there are some instances of booleans being converted to strings using `strconv.FormatBool', and then calling `setDeviceParamIfDefined' with this value, meaning that the value always gets set in the request. This commit removes those instances in favour of a manual boolean check, which can result in adding the parameter to the request only if it is set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The `setDeviceParamIfDefined' function only works on strings, and checks that the value is not empty before adding the parameter to the request.
In the builder code, in several places, there are some instances of booleans being converted to strings using
strconv.FormatBool', and then callingsetDeviceParamIfDefined' with this value, meaning that the value always gets set in the request.This commit removes those instances in favour of a manual boolean check, which can result in adding the parameter to the request only if it is set to true.