clone: Add dhcp and auto options for ipconfig #177
Conversation
DHCP doesn't get enabled automatically when no option is given. Add and document the options to enable DHCP or SLAAC.
| @@ -66,7 +66,7 @@ func (c *Config) Prepare(raws ...interface{}) ([]string, []string, error) { | |||
| } | |||
| } | |||
| for _, i := range c.Ipconfigs { | |||
| if i.Ip != "" { | |||
| if i.Ip != "" && i.Ip != "dhcp" { | |||
There was a problem hiding this comment.
Out of curiosity, if we set it to dhcp, how is it forwarded to PVE? Same for IPv6 and SLAAC, how is it forwarded to PVE?
Also, if nothing is set, what's the behaviour for this?
There was a problem hiding this comment.
If the string matches dhcp (or auto for IPv6) it gets forwarded to PVE unchanged.
The PVE likewise just passes values matching auto or dhcp directly to the Cloud-Init network configuration.
The code of the PVE side is here: https://github.com/proxmox/qemu-server/blob/master/PVE/QemuServer/Cloudinit.pm#L186
There was a problem hiding this comment.
According to the above link, if ip or ip6 are not set, the resulting network configuration won't contain address entries.
There was a problem hiding this comment.
Sounds good to me then, thanks for the explanation!
|
Merging this PR, thanks again for the contribution @sebastian-de! |
Contrary to the initial Cloud-Init networking PR (#142) DHCP has to be enabled explicitly.
Add and document the options to enable DHCP or SLAAC.
Tested on PVE 7.3.