Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix machine attribute docs #156

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

lbajolet-hashicorp
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp commented Feb 10, 2023

The machine attribute docs mistakenly documented the possible values as either i440fx or q35, while the code checked for pc, pc-i440fx or q35.

To make the documentation closer to what the code actually does, we update this section.

Reported by #154

The machine attribute docs mistakenly documented the possible values as
either i440fx or q35, while the code checked for pc, pc-i440fx or q35.

To make the documentation closer to what the code actually does, we
update this section.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner February 10, 2023 16:53
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 593535f into main Feb 10, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the machine_docs_fix branch February 10, 2023 17:02
@lbajolet-hashicorp lbajolet-hashicorp added the documentation Improvements or additions to documentation label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants