Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names of registered builders #120

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fix names of registered builders #120

merged 1 commit into from
Oct 31, 2022

Conversation

sebastian-de
Copy link
Contributor

Fixes duplicate "proxmox-" prefixes in builder names when running the plugin as an external process.

Doesn't affect bundling by Packer since builder names are defined in vendored_plugins.go

Closes #119

Fixes duplicate "proxmox-" prefixes in builder names when running the plugin as an external process.
@sebastian-de sebastian-de requested a review from a team as a code owner October 31, 2022 14:17
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 31, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, what a great catch. Thanks for the fix. I will circle back and answer your questions on the issue, and will work to get this released as soon as possbile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin won't load when installed as external plugin
3 participants