Updated doc and prepare

hashicorp · Sep 12, 2023 · b41e909 · b41e909
1 parent 7e7a7f5
commit b41e909
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/.web-docs/components/builder/clone/README.md b/.web-docs/components/builder/clone/README.md
@@ -439,6 +439,8 @@ Example:
 
 - `ssd` (bool) - Drive will be presented to the guest as solid-state drive
   rather than a rotational disk.
+
+  This cannot work with virtio disks.
 
 <!-- End of code generated from the comments of the diskConfig struct in builder/proxmox/common/config.go; -->
 

diff --git a/.web-docs/components/builder/iso/README.md b/.web-docs/components/builder/iso/README.md
@@ -651,6 +651,8 @@ Example:
 
 - `ssd` (bool) - Drive will be presented to the guest as solid-state drive
   rather than a rotational disk.
+
+  This cannot work with virtio disks.
 
 <!-- End of code generated from the comments of the diskConfig struct in builder/proxmox/common/config.go; -->
 

diff --git a/builder/proxmox/common/config.go b/builder/proxmox/common/config.go
@@ -328,6 +328,8 @@ type diskConfig struct {
 	Discard bool `mapstructure:"discard"`
 	// Drive will be presented to the guest as solid-state drive
 	// rather than a rotational disk.
+	//
+	// This cannot work with virtio disks.
 	SSD bool `mapstructure:"ssd"`
 }
 
@@ -611,6 +613,12 @@ func (c *Config) Prepare(upper interface{}, raws ...interface{}) ([]string, []st
 				}
 			}
 		}
+		if disk.SSD {
+			// SSD emulation is not supported on virtio device type
+			if disk.Type == "virtio" {
+				errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("SSD emulation is not supported on a virtio disk"))
+			}
+		}
 		if disk.StoragePool == "" {
 			errs = packersdk.MultiErrorAppend(errs, fmt.Errorf("disks[%d].storage_pool must be specified", idx))
 		}

diff --git a/docs-partials/builder/proxmox/common/diskConfig-not-required.mdx b/docs-partials/builder/proxmox/common/diskConfig-not-required.mdx
@@ -32,5 +32,7 @@
 
 - `ssd` (bool) - Drive will be presented to the guest as solid-state drive
   rather than a rotational disk.
+
+  This cannot work with virtio disks.
 
 <!-- End of code generated from the comments of the diskConfig struct in builder/proxmox/common/config.go; -->