feat: support skipping image creation #186
Conversation
|
|
Adds the config option `skip_create_image` to the builders to support skipping image creation. Fixes: hashicorp#180
jkoelker
force-pushed
the
skip_image_capture
branch
from
af90612 to
0fea610
Compare
|
Please let me know if this shared step approach is desirable. For CI purposes, I really only need something for the |
|
I looked into the CI failures and it looks like they are existing in the repo due to commented out code. Please let me know if you want me to fix them. I took a stab at it briefly, but realized that the commented code and related issues with it may be part of a larger plan that I'm unaware of. |
|
Thanks for opening up this PR. We'll work on getting this reviewed as soon as we can to get you feedback on the changes. |
|
@nywilken any update? We need this merge too :) |
|
@nywilken @sylviamoss Can we prioritize this PR? We have customers block on this. Sorry for pinging again. |
There was a problem hiding this comment.
Hi @jkoelker and all,
I've spent a bit of time today getting up to speed on this PR, testing it for myself, and thinking about the change.
Overall it's a very good, kudos @jkoelker! I pointed out a place where we could add another unit test, and I think it would be good to include some example packer template files for this field, but I do not want to block merging of this PR on either of those issues.
I will look into back filling those two things soon, but would of course appreciate a PR adding them.
Merging.
| "github.com/hashicorp/packer-plugin-azure/builder/azure/common" | ||
| ) | ||
|
|
||
| func TestSkipCreateImage(t *testing.T) { |
There was a problem hiding this comment.
I think we should add a test case here where we pass in false for SkipCreateImage, but this is good for now.
|
@jkoelker @JenGoldstrich Thank you! |
Adds the config option
skip_create_imageto the builders to supportskipping image creation.
Fixes: #180