-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support skip create image #99
Feature/support skip create image #99
Conversation
58f7eeb
to
52ed287
Compare
@nywilken, would you please review this code and get this PR merged? |
@lbajolet-hashicorp Could I trouble you to review this PR 😄? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @newbieJerry, sorry for the long wait, reviewing this now.
Aside from my comments, the code looks good to me, when you've addressed them, we can merge this PR.
Pre-approving for merge later.
.gitignore
Outdated
packer-plugin-alicloud | ||
/.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks redundant with the .idea
below, is it voluntary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/.idea/ is deleted in the latest commit
builder/ecs/client.go
Outdated
@@ -117,6 +117,10 @@ const ( | |||
mediumRetryTimes = 360 | |||
) | |||
|
|||
const ( | |||
SkipCreateImage = "you set skip_create_image true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this constant used anywhere, is this still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, redundant constants are defined, which have been deleted in the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@newbieJerry @lbajolet-hashicorp thanks for pushing this forward. This looks good to me as well. I added a commit to address the conflict with the .gitignore file. But this is good to go.
Overview of the Issue
Have a flag that allows user to skip the image creation, this can be useful for test builds and rapid validation.
Reproduction Steps
Plugin and Packer Version
Simplified Packer Buildfile
Operating system and Environment details
macOS Monterey 12.6
Log Fragments and crash.log files