Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum RAM permission for the doc #84

Merged

Conversation

binkesi
Copy link
Contributor

@binkesi binkesi commented Oct 31, 2022

Hi team, when I try to use packer plugin for Alicloud, I found these are the minimum RAM permission for it to call the Alicloud APIs. Please have a review, thanks.

@binkesi binkesi requested a review from a team as a code owner October 31, 2022 10:21
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 31, 2022

CLA assistant check
All committers have signed the CLA.

@nywilken
Copy link
Contributor

@binkesi thank you for the documentation update. I would love to get this change in. Could you take a minute to sign the CLA. If it has already been signed please check that your primary GitHub email, as well as the email in the commit, matches the email you signed the CLA with.

@nywilken nywilken added the documentation Improvements or additions to documentation label Nov 15, 2022
@binkesi
Copy link
Contributor Author

binkesi commented Nov 16, 2022

@binkesi thank you for the documentation update. I would love to get this change in. Could you take a minute to sign the CLA. If it has already been signed please check that your primary GitHub email, as well as the email in the commit, matches the email you signed the CLA with.

Thank you! You're right, I found that the Github Email I used for commit is just another email. So should I close this PR and use one same Github email to reopen another PR?

@nywilken
Copy link
Contributor

@binkesi seeing as you only have one commit you can manually change your author email on your fork and force push your changes. I found a small blog post illustrating how to change your email https://dev.to/brayanarrieta/how-to-change-the-git-commit-author-56mg.

If its easier to close and reopen with a new branch using the updated email that is fine too.

@binkesi binkesi force-pushed the binkesi-add-alicloud-minimum-ram-permission branch from 5c80948 to a153a6b Compare December 1, 2022 07:52
@binkesi
Copy link
Contributor Author

binkesi commented Dec 1, 2022

@nywilken Yeah, it work well! Please help to review. Thank you!

@nywilken
Copy link
Contributor

nywilken commented Dec 1, 2022

@binkesi thanks for working through the CLA bot checks.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit 12aadc1 into hashicorp:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants