Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ram_role_arn and ram_session_name arguments to allow authentication with RamRoleArn mode #79

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Add ram_role_arn and ram_session_name arguments to allow authentication with RamRoleArn mode #79

merged 5 commits into from
Nov 15, 2022

Conversation

wgjak47
Copy link
Contributor

@wgjak47 wgjak47 commented Oct 19, 2022

Authenticate with Alibaba Cloud RAM with RAM Role Arn mode if necessary. See role ARN on https://www.alibabacloud.com/help/en/resource-access-management/latest/ram-role-overview

Closes #78

@wgjak47 wgjak47 requested a review from a team as a code owner October 19, 2022 15:25
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alexyueer
Copy link
Contributor

Authenticate with Alibaba Cloud RAM with RAM Role Arn mode if necessary. See role ARN on https://www.alibabacloud.com/help/en/resource-access-management/latest/ram-role-overview

Closes #78

LGTM

nywilken
nywilken approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. There is a small typo in the documentation. I will try to update myself and merge in the changes.

builder/ecs/access_config.go Outdated Show resolved Hide resolved
docs-partials/builder/ecs/AlicloudAccessConfig-required.mdx Outdated Show resolved Hide resolved
@nywilken
Apply suggestions from code review
d907285 
Fix documentation for `ram_session_name`
@nywilken nywilken merged commit f50041d into hashicorp:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexyueer alexyueer alexyueer left review comments

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RamRoleArn mode is not supported when profile is used
4 participants
@wgjak47 @hashicorp-cla @alexyueer @nywilken