Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make split between e2e and integration tests explicit #9091

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

tgross
Copy link
Member

@tgross tgross commented Oct 14, 2020

Currently we compile (but don't run) the e2e tests as part of test-other,
which is skipped for branches named e2e-*. Move this check into the
test-e2e job. Split out the vault compatibility integration check as its own
makefile target for clarity.

Prevents issues like #9089 from slipping by e2e branches and into master.

Currently we compile (but don't run) the e2e tests as part of `test-other`,
which is skipped for branches named `e2e-*`. Move this check into the
`test-e2e` job. Split out the vault compatibility integration check as its own
makefile target for clarity.
@tgross tgross force-pushed the ci-split-out-integration branch from b2b4f62 to dddac0b Compare October 14, 2020 18:09
@tgross tgross marked this pull request as ready for review October 14, 2020 18:27
@tgross tgross requested review from notnoop and cgbaker October 14, 2020 18:27
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tgross tgross merged commit b2fb40e into master Oct 14, 2020
@tgross tgross deleted the ci-split-out-integration branch October 14, 2020 18:53
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
…9091)

Currently we compile (but don't run) the e2e tests as part of `test-other`,
which is skipped for branches named `e2e-*`. Move this check into the
`test-e2e` job. Split out the vault compatibility integration check as its own
makefile target for clarity.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants