Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Always show the scaling events accordion #8714

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

@lgfa29 and @drewbailey both independently suggested this change, and that's good enough justification for me.

@github-actions
Copy link

github-actions bot commented Aug 22, 2020

Ember Asset Size action

As of 3c8a7d3

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -41 B +6 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Aug 22, 2020

Ember Test Audit comparison

master 3c8a7d3 change
passes 1381 1381 0
failures 0 0 0
flaky 0 0 0
duration 6m 54s 425ms 6m 10s 088ms -44s 337ms

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change the test name to no longer say “a timeline is shown instead of an accordion” but 👍🏻👍🏻😀

@DingoEatingFuzz DingoEatingFuzz force-pushed the f-ui/always-show-scale-event-accordion branch from f78ac9d to 3c8a7d3 Compare August 24, 2020 17:34
@DingoEatingFuzz DingoEatingFuzz merged commit adb0610 into master Aug 24, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui/always-show-scale-event-accordion branch August 24, 2020 18:07
@DingoEatingFuzz
Copy link
Contributor Author

I updated the test name 🙈

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants