Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: expand explanation of task driver capabilities #8485

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

tgross
Copy link
Member

@tgross tgross commented Jul 21, 2020

Builds on top of #8476 to add a little more detail to the task driver capabilities documentation. The text of the isolation modes is mostly coming out of plugins/drivers/driver.go#L125-L139 and plugins/drivers/driver.go#L172-L187

@tgross tgross requested review from angrycub, jrasell and notnoop July 21, 2020 19:00
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super useful!

@tgross
Copy link
Member Author

tgross commented Jul 22, 2020

After an internal discussion including @schmichael, I've updated this PR to make human readable / descriptive keys on the task driver pages.

@tgross tgross requested a review from jrasell July 22, 2020 12:25
website/pages/docs/drivers/docker.mdx Outdated Show resolved Hide resolved
@tgross tgross force-pushed the doc-task-driver-internals branch from c5a3747 to 74ee80e Compare July 22, 2020 15:55
@tgross
Copy link
Member Author

tgross commented Jul 22, 2020

Ok, I've double-checked the deploy preview and this looks good-to-merge.

@tgross tgross merged commit 31be70b into master Jul 22, 2020
@tgross tgross deleted the doc-task-driver-internals branch July 22, 2020 16:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants