retry copy if copy receives EOF but task is still running #8149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbailey
force-pushed
the
logmon-retry-copy
branch
from
d7d997c to
efacb1e
Compare
drewbailey
changed the title
|
closing in favor of #8155 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task drivers that don't utilize the fifo package for opening logmons fifo run into an issue where after an allocation is restarted, the io.Copy reaches EOF and we never retry. This causes the LXC and Podman driver to no longer log after an allocation restart.
Our docker_logger and executor based task drivers have long running processes that keep the io.Copy open during allocation restarts but other community drivers whose process changes during allocation restart are affected by this.