Deflake some tests - 2020-05-27 edition #8060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 26, 2020 18:53
Fix some docker test flakiness where image cleanup process may contaminate other tests. A clean up process may attempt to delete an image while it's used by another test.
tgross
approved these changes
May 27, 2020
nomad/node_endpoint_test.go
Outdated
| case structs.EvalStatusPending, structs.EvalStatusComplete: | ||
| // success | ||
| default: | ||
| require.Equal(t, structs.EvalStatusPending, eval.Status) |
There was a problem hiding this comment.
If we saying EvalStatusPending or EvalStatusComplete are the success case, do you think this would be more clear (and provide more accurate error messages) if we used assert.Fail here instead?
nomad/drainer_int_test.go
Outdated
| require.Len(node.Events, 3) | ||
|
|
||
| // sometimes test gets a duplicate node drain complete event | ||
| if len(node.Events) < 3 { |
There was a problem hiding this comment.
Could we use require.GreaterOrEqual to make the intent more clear?
notnoop
force-pushed
the
tests-deflake-20200526
branch
from
c6c8bbe to
74af591
Compare
notnoop
pushed a commit
that referenced
this pull request
Jun 2, 2020
Deflake some tests - 2020-05-27 edition
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deflake some tests that I noticed recently. Best reviewed on commit by commit basis:
In high level, I noticed the following:
Fixed this by ensuring that background goroutines are cancelled after the driver context is cancelled. Also, default to having tests run with disabled GC.
Some CSI tests expect the nodes to be in the Server State Store, but block until a connection is established. This results into spurious failures such as ones found in https://circleci.com/gh/hashicorp/nomad/69646 . Notice how the failure is reported 1ms after "client: node registration complete" log line.
Weird sparious failures in
apipackage like ones in https://circleci.com/gh/hashicorp/nomad/69688 , where the test pass by gets reported as a failure. My hunch is that it fails because the nomad process is killed before the log newline is flushed and gotestsum get confused. I'll report this to gotestsum developer. Here, I ensure that the process is killed gracefully first.