Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command: TestHelpers_LineLimitReader_TimeLimit() Goroutine #6678

Merged
merged 1 commit into from
Nov 12, 2019
Merged

command: TestHelpers_LineLimitReader_TimeLimit() Goroutine #6678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions command/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,25 +174,32 @@ func TestHelpers_LineLimitReader_TimeLimit(t *testing.T) {

expected := []byte("hello world")

resultCh := make(chan struct{})
errCh := make(chan error)
resultCh := make(chan []byte)
go func() {
defer close(resultCh)
defer close(errCh)
outBytes, err := ioutil.ReadAll(limit)
if err != nil {
t.Fatalf("ReadAll failed: %v", err)
}

if reflect.DeepEqual(outBytes, expected) {
close(resultCh)
errCh <- fmt.Errorf("ReadAll failed: %v", err)
return
}
resultCh <- outBytes
}()

// Send the data
in.data <- expected
in.Close()

select {
case <-resultCh:
case err := <-errCh:
if err != nil {
t.Fatalf("ReadAll: %v", err)
}
case outBytes := <-resultCh:
if !reflect.DeepEqual(outBytes, expected) {
t.Fatalf("got:%s, expected,%s", string(outBytes), string(expected))
}
case <-time.After(1 * time.Second):
t.Fatalf("did not exit by time limit")
}
Expand Down