Use joint context to cancel prestart hooks #6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
notnoop
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
This looks like a good improvement.
Though I'd be curious what the state of alloc/task when template rendering fails. Ideally, the alloc gets marked as failed, and then nomad client may free/gc up alloc as necessary. Doing so may require us to fix template failure handling but i'm not 100% sure.
schmichael
reviewed
Sep 30, 2019
schmichael
approved these changes
Sep 30, 2019
fixes #6382 The prestart hook for templates blocks while it resolves vault secrets. If the secret is not found it continues to retry. If a task is shutdown during this time, the prestart hook currently does not receive shutdownCtxCancel, causing it to hang. This PR joins the two contexts so either killCtx or shutdownCtx cancel and stop the task.
drewbailey
force-pushed
the
b-missing-vault-sercret
branch
from
a8aeae0 to
6cf5573
Compare
defer shutdown to cleanup after failed run Co-Authored-By: Michael Schurter <[email protected]> update comment to include ctx note for shutdown
drewbailey
force-pushed
the
b-missing-vault-sercret
branch
from
6cf5573 to
12be120
Compare
This was referenced Oct 8, 2019
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prestart hook for templates blocks while it resolves vault secrets.
If the secret is not found it continues to retry. If a task is shutdown
during this time, the prestart hook currently does not receive
shutdownCtxCancel, causing it to hang.
This PR joins the two contexts so either killCtx or shutdownCtx cancel
and stop the task.
fixes #6382