Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host Volumes Support: Rollup Edition #6100

Merged
merged 17 commits into from
Aug 12, 2019
Merged

Host Volumes Support: Rollup Edition #6100

merged 17 commits into from
Aug 12, 2019

Conversation

endocrimes
Copy link
Contributor

@endocrimes endocrimes commented Aug 9, 2019 •
edited
Loading

This PR is a rollup PR for Host Volumes Support. All code has been reviewed in separate PRs and will eventually be merged into master from here.

PRs:

@endocrimes endocrimes marked this pull request as ready for review August 12, 2019 13:32
endocrimes and others added 16 commits August 12, 2019 15:39
@endocrimes
jobspec: Add Volume and VolumeMount declarations
ad72d16
@endocrimes
structs: Add declarations of basic structs for volume support
8514893
@endocrimes
client: Add parsing and registration of HostVolume configuration
86b4296
@endocrimes
api: Allow submission of jobs with volumes
a216dae
@endocrimes
scheduler: Add a feasability checker for Host Vols
709abbc
@endocrimes
client: Add volume_hook for mounting volumes
c3c003d
@endocrimes
Update scheduler/feasible.go
0f5cf5f 
Co-Authored-By: Mahmood Ali <[email protected]>
@endocrimes
structs: Unify Volume and VolumeRequest
af5d42c
@endocrimes
HostVolumeConfig: Source -> Path
7b7be83
@endocrimes
structs: Document VolumeMount
869f1da
@endocrimes
api: Add HostVolumeInfo to response parsing
346444b
@endocrimes
cli: Display host volume info in nomad node status
f478c8c
@endocrimes
command: Cleanup node-status
a86a077
@endocrimes
acl: Add HostVolume ACLs
065688d 
This adds an initial implementation of ACLs for HostVolumes.

Because HostVolumes are a cluster-wide resource, they cannot be tied to
a namespace, thus here we allow similar wildcard definitions based on
their names, tied to a set of capabilities.

Initially, the only available capabilities are deny, or mount. These
may be extended in the future to allow read-fs, mount-readonly and
similar capabilities.
@endocrimes
job_endpoint: Validate volume permissions
547a454
@endocrimes
fixup rebase
e57cf06
notnoop
notnoop reviewed Aug 12, 2019
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good as much of it has already been reviewed, but I'd love high level documentation for core types before merging to master.

api/tasks.go Outdated Show resolved Hide resolved
client/config/config.go Show resolved Hide resolved
jobspec/parse_group.go Outdated Show resolved Hide resolved
nomad/job_endpoint.go Show resolved Hide resolved
@endocrimes endocrimes requested a review from notnoop August 12, 2019 14:42
preetapan
preetapan approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@preetapan preetapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@endocrimes endocrimes merged commit 0c80fcb into master Aug 12, 2019
@endocrimes endocrimes deleted the f-host-volumes branch August 12, 2019 14:58
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@preetapan preetapan preetapan approved these changes

@notnoop notnoop Awaiting requested review from notnoop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endocrimes @notnoop @preetapan