-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value "3m" to image_delay, making it consistent with docs. #6078
Add default value "3m" to image_delay, making it consistent with docs. #6078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It does match the documentation. I'm going to ask for one more confirmation, but it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I think i've been hit by nomad deleting images prematurely without fully understanding why. Thanks for catching this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change just needs to be rebased on master
in order for the tests to pass
fb2ff8b
to
e7eede5
Compare
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - This was actually catching me a bunch last week but I didn't get a chance to debug
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Currently,
image_delay
defaults to 0, causing nomad client to delete docker images the moment they become unused.This is not the expected behavior according to docs:
https://www.nomadproject.io/docs/drivers/docker.html#image_delay