Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the prefix of the service id #579

Merged
merged 2 commits into from
Dec 14, 2015
Merged

Changing the prefix of the service id #579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dffcc8b
Changing the prefix of the service id
diptanu Dec 14, 2015
68b1dd0
Changing the prefix of the service
diptanu Dec 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nomad/structs/structs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ func (sc *ServiceCheck) Hash(serviceId string) string {
}

const (
NomadConsulPrefix = "nomad"
NomadConsulPrefix = "1729nomad"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have to be a number? Why not: [nomad-registered-service]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or n0m4d ;D Honestly, that's a minor detail to me, as long as it does not easily clash with users's service IDs I'm ok with whatever prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't care much either. Fixing a test, might as well make it what Alex suggested so that it's more human readable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

)

// The Service model represents a Consul service defintion
Expand Down