Fix restart attempts of restart stanza in delay mode.

[fwkz]

restart {
  interval = "1m"
  attempts = 2
  delay    = "5s"
  mode     = "delay"
}

Imagine constantly failing job with restart policy in mode delay, starting from 2nd interval every subsequent one gets one extra restart attempt. Root cause stems from the fact that attempts counter is being reset (line no. 178) just after it was incremented.

                                        +
            1st INTERVAL                |          2nd INTERVAL
            all good                    |          one extra restart
                                        |
                                        |
     initial      1st       2nd         |     initial      1st        2nd       3rd
     attempt      restart   restart     |     attempt      restart    restart   EXTRA restart
                                        |
        +           +        +          |         +           +          +          +
        |           |        |          |         |           |          |          |
        |           |        |          |         |           |          |          |
        |           |        |          |         |           |          |          |
        |           |        |          |         |           |          |          |
 +-+----+-----+-----+----+---+---+----------------+-----+-----+-----+----+------+---+----->
   |    t     |          |       |      |       t+60s   |           |           |
   +          +          +       |      |               |           +           +
count=0    count=1    count=2    |      |               |        count=1     count=2
   +          +          +       +      +               +           +           +
                              count=3              count=4
                            stop and wait          but wait! It is
                            for the new            the new interval
                            interval               so reset the counter!
                                                   counter=0
                                                   (line no. 178)

If we increment counter after checking if we have entered a new interval we should by fine.

[hashicorp-cla]

All committers have signed the CLA.

[cgbaker]

wonderful, @fwkz . 0.9.2 is frozen, will merge immediately afterwards.

[fwkz]

0.9.2 is frozen, will merge immediately afterwards.

Sure, I'm glad I could help. 💪

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.