add non-empty string validation for datacenters #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
approved these changes
May 8, 2019
| } | ||
| err = j.Validate() | ||
| mErr = err.(*multierror.Error) | ||
| if !strings.Contains(mErr.Error(), "datacenter must be non-empty string") { |
There was a problem hiding this comment.
You can use testify require here instead of using Fatalf directly
Suggested change
| if !strings.Contains(mErr.Error(), "datacenter must be non-empty string") { | |
| require.Contains(t, mErr.Error(), "datacenter must be non-empty string") |
preetapan
approved these changes
May 9, 2019
jazzyfresh
added a commit
that referenced
this pull request
May 13, 2019
nickethier
added a commit
that referenced
this pull request
May 14, 2019
* master: (912 commits) Update redirects.txt Added redirect for Spark guide link client: log when server list changes docs: mention regression in task config validation fix update to changelog update CHANGELOG with datacenter config validation #5665 typo: "atleast" -> "at least" implement nomad exec for rkt docs: fixed typo use pty/tty terminology similar to github.com/kr/pty vendor github.com/kr/pty drivers: implement streaming exec for executor based drivers executors: implement streaming exec executor: scaffolding for executor grpc handling client: expose allocated memory per task client improve a comment in updateNetworks stalebot: Add 'thinking' as an exempt label (#5684) Added Sparrow link update links to use new canonical location Add redirects for restructing done in GH-5667 ...
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently the command agent accepts jobs with empty-string datacenters
Implementation
Add empty-string check to job validation in
nomad/structs/structs.goTODO
clean up tests (--> parameterize job validation tests?)parameterization not necessary for these tests