Add support in nomad for supporting raft 3 protocol peers.json #5629
Conversation
|
|
|
Thank you for submitting this issue and it's a bug for sure. The code is correct - but I'd love to see test for it if we can. Also, can we sign the CLA? |
| if s.config.RaftConfig.ProtocolVersion < 3 { | ||
| configuration, err = raft.ReadPeersJSON(peersFile) | ||
| } else { | ||
| configuration, err = raft.ReadConfigJSON(peersFile) |
There was a problem hiding this comment.
Now that I think about it - when running under version 3 - we may need to attempt to read in both formats. I'll double check the raft track - but I suspect at version 2 - it starts writing peers file in new format. Nevermind, this matches consul implementation in https://github.com/hashicorp/consul/pull/3007/files . Thanks!
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Seeing the following error while following https://www.nomadproject.io/guides/operations/outage.html for raft protocol 3.
nomad: failed to start Raft: recovery failed to parse peers.json: json: cannot unmarshal object into Go value of type string
This PR fixes the above issue.