Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil pointer in fingerprinting AWS env leading to crash #5583

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

ygersie
Copy link
Contributor

@ygersie ygersie commented Apr 19, 2019

HTTP Client returns a nil response if an error has occured. We first
need to check for an error before being able to check the HTTP response
code.

  HTTP Client returns a nil response if an error has occured. We first
  need to check for an error before being able to check the HTTP response
  code.
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 19, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

@schmichael schmichael merged commit 8a0df40 into hashicorp:master Apr 19, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants