docker: Return undetected before first detection #5362
Conversation
This commit causes the docker driver to return undetected before it first establishes a connection to the docker daemon. This fixes a bug where hosts without docker installed would return as unhealthy, rather than undetected.
There was a problem hiding this comment.
lgtm.
I may suggest reusing fingerprintLock and having setFingerprintSuccess set detected to true; as fingerprintSuccess and detected (which is more like fingerprintEverWasSuccessful) are related and should be updated together.
Also, anyway we add a test for this?
|
There's no particularly useful way to write a test for this without a lot of faking things for go-dockerclient afaik :/ (we currently don't really have anything in the way of fingerprint tests for docker :() I actually want to explicitly keep this as is, because it would be fairly easy to introduce a bug if we added further validation steps if it was rolled in to setFingerprintSuccessful. (e.g detected but unhealthy if we were to validate more network things, or after #5356 is merged) |
|
waiting for beta3 ... I too noticed this when I started some experiments with beta2 for nvidia 👍 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Preview: https://asciinema.org/a/229631
fixes #5320
This causes the docker driver to return undetected before the daemon is available, for a better experience when hosts do not have docker installed.
After the first detection it then returns unhealthy if it subsequently goes away.
sidenote:
It appears that we do keep fingerprinting drivers if they return undetected, which I did not think was the case.