-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added options for adding more consul configuration #503
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ee14aa2
Added options for adding more consul configuration
diptanu 11039cd
Added docs for consul options
diptanu 61e386c
Fixed some spellings in old docs
diptanu 402c355
Moved some docs around
diptanu 7e9554f
Removed redundant doc
diptanu eedc99c
Fixed the build
diptanu 6fdedac
Removed fingerprint docs from Service Discovery docs
diptanu eaea4f6
Fixed the alloc runner test
diptanu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,29 @@ Nomad does not currently run Consul for you. | |
override the default Consul Agent HTTP port that Nomad uses to connect to | ||
Consul. The default for this is `127.0.0.1:8500`. | ||
|
||
* `consul.token`: Token is used to provide a per-request ACL token.This options | ||
overrides the agent's default token | ||
|
||
* `consul.auth`: The auth information to use for http access to the Consul | ||
Agent. | ||
|
||
* `consul.ssl`: This boolean option sets the transport scheme to talk to the Consul | ||
Agent as `https`. This option is unset by default and so the default transport | ||
scheme for the consul api client is `http`. | ||
|
||
* `consul.verifyssl`: This option disables SSL verification when the transport | ||
scheme for the Consul API client is `https`. This is set to true by default. | ||
|
||
* `driver.whitelist`: A comma separated list of whitelisted drivers (e.g. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The whitelists shouldn't be here. |
||
"docker,qemu"). If specified, drivers not in the whitelist will be disabled. | ||
If the whitelist is empty, all drivers are fingerprinted and enabled where | ||
applicable. | ||
|
||
* `fingerprint.whitelist`: A comma separated list of whitelisted fingerprinters. | ||
If specified, fingerprinters not in the whitelist will be disabled. If the | ||
whitelist is empty, all fingerprinters are used. | ||
|
||
|
||
## Service Definition Syntax | ||
|
||
The service blocks in a Task definition defines a service which Nomad will | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should just build the config and pass it to NewConsulService or just pass the client config in so it can do all this stuff. Mainly I don't like that you have to pass so many arguments in.