Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track all client connections #4222

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Track all client connections #4222

merged 2 commits into from
Apr 26, 2018

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Apr 26, 2018

Fixes an issue in which the server could loose a reference to a client even if the client was connected to it. In order for this to happen, the client would connect to a server over address A. Then at some point, heartbeats or Consul discovery, the client's server set is updated to connect via address B. Both of these address would resolve to the same server but the server would clear out the connection first made from connecting via Address A. Eventually address B connection would be closed because it is idle and isn't being used by the client.

Now the state is the client still has a connection via Address A but the server has no reference to the client at all.

Fixes #4203

@dadgar dadgar merged commit 821a223 into master Apr 26, 2018
@dadgar dadgar deleted the b-proxy branch April 26, 2018 21:46
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No stats in alloc-status in nomad 0.8.1 (no path to node)
2 participants