Get Qemu to fingerprint and test properly on both windows and linux #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t.Skip("Must be on non-windows environments to run test") | ||
| } | ||
| // else see if qemu exists | ||
| // Check if qemu exists | ||
| _, err := exec.Command("qemu-system-x86_64", "-version").CombinedOutput() |
There was a problem hiding this comment.
We need the same check here to run tests on windows
There was a problem hiding this comment.
It still works because that binary returns without an exit code but it is confusing. Updated
|
@dadgar LGTM |
| if runtime.GOOS != "windows" && syscall.Geteuid() != 0 { | ||
| d.logger.Printf("[DEBUG] driver.qemu: must run as root user, disabling") | ||
| return false, nil | ||
| bin := "qemu-system-x86_64" |
There was a problem hiding this comment.
Add a small comment here around why we are switching commands?
dadgar
added a commit
that referenced
this pull request
Oct 29, 2015
Get Qemu to fingerprint and test properly on both windows and linux
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows
qemu-system-x86_64does not respond to--versionbutqemu-imgdoes. Also removed the precondition that you have to be root because you don't