Fix flaky tests #3434
Fix flaky tests #3434
Conversation
|
The most recent failure from the TestStateStore_Blocking_Timeout is fixed on master which is why I haven't fixed it in this PR |
| @@ -221,15 +221,14 @@ test: ## Run the Nomad test suite and/or the Nomad UI test suite | |||
| fi | |||
|
|
|||
| .PHONY: test-nomad | |||
| test-nomad: LOCAL_PACKAGES = $(shell go list ./... | grep -v '/vendor/') | |||
There was a problem hiding this comment.
Good riddance grep -v vendor!
client/driver/docker_test.go
Outdated
| func dockerTask(t *testing.T) (*structs.Task, int, int) { | ||
| ports := freeport.GetT(t, 2) | ||
| docker_reserved := ports[0] | ||
| docker_dynamic := ports[1] |
There was a problem hiding this comment.
If you're touching this mind updating the variable naming to match regular Go style?
| @@ -265,7 +265,7 @@ func TestRawExecDriver_HandlerExec(t *testing.T) { | |||
| Driver: "raw_exec", | |||
| Config: map[string]interface{}{ | |||
| "command": testtask.Path(), | |||
| "args": []string{"sleep", "9000"}, | |||
| "args": []string{"sleep", "9000s"}, | |||
There was a problem hiding this comment.
This looks like it was fun to debug. :)
There was a problem hiding this comment.
Took me so long! Literally went home after I found the bug. I was just done haha
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.